Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where Sliding Sync could get stuck when using workers #17438

Merged
merged 10 commits into from
Jul 15, 2024
Merged

Fix bug where Sliding Sync could get stuck when using workers #17438

merged 10 commits into from
Jul 15, 2024

Commits on Jul 12, 2024

  1. Fix bug where sync could get stuck when using workers 

    This is because we serialized the token wrong if the instance map
contained entries from before the minimum token.
    @erikjohnston
    erikjohnston committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    bf09110 View commit details
    Browse the repository at this point in the history

  2. Add assertion to MultiWriterTokens

    @erikjohnston
    erikjohnston committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d2c8d48 View commit details
    Browse the repository at this point in the history

  3. Newsfile

    @erikjohnston
    erikjohnston committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    6d86303 View commit details
    Browse the repository at this point in the history

  4. Handle existing dodgy tokens

    @erikjohnston
    erikjohnston committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    31e6508 View commit details
    Browse the repository at this point in the history

  5. Test both types of token

    @erikjohnston
    erikjohnston committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    940b644 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Andrew Morgan <[email protected]>
    @erikjohnston @anoadragon453
    erikjohnston and anoadragon453 authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4bf6b06 View commit details
    Browse the repository at this point in the history

  7. Review comments

    @erikjohnston
    erikjohnston committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    0ccc295 View commit details
    Browse the repository at this point in the history

  8. Add test

    @erikjohnston
    erikjohnston committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2a49675 View commit details
    Browse the repository at this point in the history

  9. Fix sliding sync

    @erikjohnston
    erikjohnston committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    224a739 View commit details
    Browse the repository at this point in the history

  10. Fix bound_stream_token

    @erikjohnston
    erikjohnston committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    546c2a8 View commit details
    Browse the repository at this point in the history