Remove images from message notification e-mails. #17598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier 'reivilibre <[email protected]>
| @@ -1,19 +1,6 @@ | |||
| {%- for message in notif.messages %} | |||
| <tr class="{{ "historical_message" if message.is_historical else "message" }}"> | |||
| <td class="sender_avatar"> | |||
There was a problem hiding this comment.
Should we remove this column entirely?
| @@ -1,17 +1,6 @@ | |||
| <table class="room"> | |||
| <tr class="room_header"> | |||
| <td class="room_avatar"> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having these images here has been a liability because it gives cause for complaints about the e-mails,
which then affects our sender reputation.
These images will also be broken by the upcoming media authentication changes, so there's little point in keeping them around either.
Base:
developOriginal commit schedule, with full messages:
Remove images from message notification e-mails
Remove room avatars from message notification e-mails