Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify when 3PID invite module callbacks are called #17627

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Clarify when 3PID invite module callbacks are called #17627

merged 3 commits into from
Oct 14, 2024

Conversation

anoadragon453
Copy link
Member

As folks were asking when these methods actually fire.

Please do double-check this is correct 🙂

@anoadragon453 anoadragon453 marked this pull request as ready for review August 29, 2024 13:52
@anoadragon453 anoadragon453 requested a review from a team as a code owner August 29, 2024 13:52
@github-actions github-actions bot deployed to PR Documentation Preview August 29, 2024 13:52 Active
MadLittleMods
MadLittleMods approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@MadLittleMods MadLittleMods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right after looking at the code

docs/modules/spam_checker_callbacks.md Outdated Show resolved Hide resolved
@anoadragon453
Copy link
Member Author

Thanks for the additional clarification!

@anoadragon453 anoadragon453 merged commit 451a9dc into develop Oct 14, 2024
11 checks passed
@anoadragon453 anoadragon453 deleted the anoa/clarify_3pid_callbacks branch October 14, 2024 10:31
@github-actions github-actions bot deployed to PR Documentation Preview October 14, 2024 10:32 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadLittleMods MadLittleMods MadLittleMods approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoadragon453 @MadLittleMods