Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOL doesn't seem to propagate to Flatpak remote #484

Closed
cassidyjames opened this issue Sep 25, 2023 · 3 comments · Fixed by #529
Closed

EOL doesn't seem to propagate to Flatpak remote #484

cassidyjames opened this issue Sep 25, 2023 · 3 comments · Fixed by #529

Comments

@cassidyjames
Copy link
Contributor

What Happened?

The only examples I see of EOL apps still show their pre-EOL updates in AppCenter, and don't warn when installing or updating from the CLI.

  • Dippi
  • Clairvoyant
  • Principles
  • Palette
  • LookBook

In all cases, the apps are showing the release information before their respective EOL update in the remote's AppStream data. For example, installing or updating LookBook doesn't recommend installing Icon Browser from the Flatpak CLI, and Clairvoyant is still showing its 2.0.0 release, meaning the 2.0.1 release never made it into the remote.

Steps to Reproduce

  1. Mark an app as EOL in this repo, either with no other updates (like Dippi), with a version bump (like Clairvoyant), or with a rebase (like LookBook).
  2. Merge it
  3. See that the app's update never comes through to the AppCenter remote, AppStream data, Flatpak CLI, AppCenter native client, or AppCenter website

Expected Behavior

Marking an app as EOL in this repo should propagate that information to the Flatpak remote.

OS Version

7.x (Horus)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

@davidmhewitt
Copy link
Member

This looks to be a problem in Flatpak's GitHub actions, PR to fix it submitted here: flatpak/flatpak-github-actions#157

Once that's fixed, I'll re-run the publish for your recent EoL'd apps and let you know.

@cassidyjames
Copy link
Contributor Author

Thanks, @davidmhewitt!

@davidmhewitt
Copy link
Member

Still progressing this, found another issue with the GitHub actions and opened another PR:
flatpak/flatpak-github-actions#160

cassidyjames added a commit to cassidyjames/appcenter-reviews that referenced this issue Aug 28, 2024
Includes @davidmhewitt's upstream fixes which should resolve elementary#484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants