Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add App Generator #534

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add App Generator #534

wants to merge 3 commits into from

Conversation

alainm23
Copy link

@alainm23 alainm23 commented Oct 8, 2024

Review Checklist

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • Custom colors meet WCAG A contrast or greater
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

io github ecommunity app-generator

@alainm23 alainm23 requested a review from a team as a code owner October 8, 2024 22:30
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for submitting this!

A major problem here is that you don't actually own this RDNN. https://github.com/ecommunity is owned by someone else. The RDNN here should be io.github.elementary-community.app-generator since that's where it's hosted. That's why I asked previously if you wanted to make move the org domain to something shorter :)

The screenshot in this release doesn't match the app as released here. I would also recommend versioning this URL so that it pulls the right screenshot, for example, it should be https://raw.githubusercontent.com/elementary-community/app-generator/1.0.0/data/io.github.ecommunity.app-generator.png

In metainfo, the <developer_name> is deprecated. The <developer> tag should be used instead https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer

<value key="x-appcenter-color-primary-text"> is no longer used. Text color is generated automatically in AppCenter

Your metainfo file is missing a <content_rating> tag. This can just be a self-closing tag if there's nothing to disclose https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-content_rating

@ryonakano
Copy link
Contributor

The RDNN here should be io.github.elementary-community.app-generator since that's where it's hosted.

Maybe it should be io.github.elementary_community.app-generator instead, because Flatpak doesn't allow use of hyphens other than the last element of the RDNN

https://docs.flatpak.org/en/latest/conventions.html#application-ids

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants