Handle-middle-click-24 #1378
Draft
Handle-middle-click-24 #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
reviewed
Nov 21, 2023
Comment on lines
-140
to
+141
| activate_action (MainWindow.ACTION_PREFIX + MainWindow.ACTION_NEW_TAB, null); | ||
| var active_window_action_group = active_window.get_action_group (MainWindow.ACTION_GROUP); | ||
| active_window_action_group.activate_action (MainWindow.ACTION_NEW_TAB, null); |
There was a problem hiding this comment.
This appears to be a separate fix unrelated to middle-click handling? If so should be submitted as a separate PR.
|
Need to check how the new elementary dock under development handles middle-click. See also elementary/dock#77 (comment) . This might be an issue that needs to be fixed in dock? It seems to me that dock needs to activate the "New Window" option in the context menu when a middle-click is used. Otherwise there needs to be some way the app knows that a middle-click was used otherwise the behaviour changes in other situations which is undesirable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
Note: Changes default behaviour when launched from terminal without command line args to create a new window