Provide a Flatpak manifest

[meisenzahl]

Closes #33

[meisenzahl]

I could use some help.

Feedback starts now, but the submenus for Default Apps, Panel Indicators and System Settings are empty. I assume that they are filled dynamically and that starting it as Flatpak will not find the applications.

[Marukesu]

Need some cleanups definitions and others minors changes.

[Marukesu]

about the appstream error, the flatpak don't have access to the host metadata, so we need to include the needed files with the flatpak, or place them in a location that the flatpak can read if setted with appstream_pool.add_metadata_location.

it fix the Painel Indicators and System Settings, but for Default Appliications it fails in create the DesktopAppInfo.

[meisenzahl]

@Marukesu thanks for your feedback!

@danrabbit what is your opinion how we want to continue?

[danirabbit]

I think it would definitely be preferable to poke the right holes in the sandbox so it can read the installed apps from the system. It would be ultimately more maintainable to reflect what the user actually has installed

[Marukesu]

adding appstream_pool.add_metadata_location ("/run/host/usr/share/metainfo") to MainWindow.vala makes the native appstream readable in the flatpak (running with --filesystem=host:ro), but it can't read the .desktop files.

(io.elementary.feedback:2): GLib-GIO-CRITICAL **: 18:52:32.607: g_app_info_get_display_name: assertion 'G_IS_APP_INFO (appinfo)' failed

(io.elementary.feedback:2): GLib-GIO-CRITICAL **: 18:52:32.607: g_app_info_get_icon: assertion 'G_IS_APP_INFO (appinfo)' failed

** (io.elementary.feedback:2): CRITICAL **: 18:52:32.607: feedback_repo_row_construct: assertion 'title != NULL' failed

(io.elementary.feedback:2): GLib-GObject-CRITICAL **: 18:52:32.607: g_object_ref_sink: assertion 'G_IS_OBJECT (object)' failed

(io.elementary.feedback:2): Gtk-CRITICAL **: 18:52:32.607: gtk_container_add: assertion 'GTK_IS_WIDGET (widget)' failed

[Marukesu]

Well, since DesktopAppInfo won't work inside the flatpak, i changed the app to use only the appstream metadata and worked. But, to have the icons, the appdata need the icon tag (none of the needed apps have it, through).

[danirabbit]

This at least builds and shows apps, I think we can follow up later with a solution for all app icons. That probably means adding icons to other components appdata files. So I think this is good to merge :)