Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wayland daemon display labels #1840

Closed
wants to merge 17 commits into from
Closed

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Jan 22, 2024

I had this wayland-daemon branch lying around and thought I might as well put it to use.

This removes the gala-daemon autostart and instead starts it as a wayland client on wayland or as a normal subprocess on x. It therefore also removes all the session stuff (not sure whether we have to do somewhere else something else too).

Furthermore it implements an API to show MonitorLabels which is pretty much taken from #1827 and from the original displaylabel in settings.
I've hardcoded the CSS and didn't gresource it since we need some hardcoded css anyways. If it should still be gresourced where would be the best place to put it? Normal data folder?
I'm not sure since what mutter version Meta.Context is required for WaylandClient creation so I guessed 43 which would fit with the commit date. Is there a good way to find this version?

This is an alternative to #1827 and works on both X and wayland.

Closes #1827
Fixes #1823
Probably fixes #1826

@leolost2605 leolost2605 marked this pull request as ready for review January 22, 2024 14:53
@leolost2605 leolost2605 requested a review from a team January 22, 2024 14:53
@leolost2605
Copy link
Member Author

For testing one can use elementary/switchboard-plug-display#372

@bobby285271
Copy link
Member

Given that mutter!2718 is not in 43, do you mind replacing the HAS_MUTTER43 in src/DaemonManager.vala with HAS_MUTTER44 since NixOS pins Mutter to 43 on Pantheon and we do need that to get this build 🙇

@leolost2605
Copy link
Member Author

Given that mutter!2718 is not in 43, do you mind replacing the HAS_MUTTER43 in src/DaemonManager.vala with HAS_MUTTER44 since NixOS pins Mutter to 43 on Pantheon and we do need that to get this build 🙇

Sure seems I guessed wrong then 😅

@danirabbit
Copy link
Member

@lenemter Can you take a look at this? I think these labels are currently the biggest blocker for this gtk4 port :)

@leolost2605
Copy link
Member Author

I would actually kinda prefer to go with #1844 first and then I'll push a new branch with display labels based on that one since it's quite a bit better than this one and with less changes. The bigger diff there is just because I moved both menus into separate files.

@lenemter
Copy link
Member

@leolost2605 resolve conflicts here please

@leolost2605
Copy link
Member Author

See #1861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing gala-daemon systemd service API for display labels
4 participants