Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WindowManager: Allow making modal without a grab #1860

Closed
wants to merge 1 commit into from
Closed

WindowManager: Allow making modal without a grab #1860

wants to merge 1 commit into from

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Feb 18, 2024 •
edited
Loading

  • This allows making the WindowManager modal without a stage grab
  • Useful if you just want to block keybindings
  • Fixes being able to switch workspaces while a window menu is active which was brought up by @lenemter in Wayland menus #1844
  • It's an API break (I think?) but I'm not sure anybody except for us currently uses gala api?
  • Will also be useful if we want to introduce a shell modal hint for windows

@leolost2605 leolost2605 requested a review from a team February 18, 2024 12:14
lenemter
lenemter requested changes Feb 19, 2024
View reviewed changes
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The menu is not clickable at all in this branch.

@leolost2605
Copy link
Member Author

Yeah and it doesn't even do what it was supposed to do so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenemter lenemter lenemter requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leolost2605 @lenemter