Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devices: clean up 128 drive-harddisk #1224

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Conversation

danirabbit
Copy link
Member

This icon still needs a much bigger redraw, but hopefully this makes it suck ever so slightly less for now

@newhoa
Copy link
Collaborator

newhoa commented Jul 26, 2023

I tried a little refresh to the solid state icon a few months ago but got side tracked and never finished. Tried to update the symmetry, with updated borders/gradients, and rounded edges.

drive-harddisk-solidstate solidstate-prop2

Right direction? Something I should continue working on? Figured I'd throw it here since it fits the subject (or if anyone else wants to pick it up). Any feedback would be appreciated!

Copy link
Member

@micahilbery micahilbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I think if nothing else the borders/strokes are a big improvement.

@danirabbit danirabbit enabled auto-merge (squash) January 26, 2024 06:56
@danirabbit danirabbit merged commit 906e4da into main Jan 26, 2024
3 checks passed
@danirabbit danirabbit deleted the danirabbit/harddisk-128 branch January 26, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants