Status: Use chat bubbles for user- icons
#1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the colored dot `user-` prefixed icons with chat bubbles. This more closely follows the FreeDesktop.org Icon Naming Spec which describes them as chat icons. Remove non-FD.o `user-` icons. Fixes issue where the fullcolor and symbolic icons used different styles. Closes elementary#1307 Note: Apps that used the dots as general status icons should now use the dots found in emblems folder. (e.g. use `emblem-disabled` instead of `user-offline`)
danirabbit
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the chat app style as the basis for this one. Hopefully this PR is okay as-is, but I'll add some notes and alternatives below. Let me know if anything needs changing. Thanks!
user-offlineused anxemblem on the symbolic icon, so I stuck with that. I tried the "disabled" slash. I thought it was kind of hard to make the chat bubble out since the slash blocks the tail. I'll put it here in case you all would rather go with that, just let me know:Current:
Alternative:
Possible issue, the 16px icons are 16px wide. I tried to do 14px wide, but it ended up either circular looking or the height needed to be reduced such that it just looked too small, especially for adding emblems inside. Personally I like the 16px one a lot more, but if 14px is needed or looks better let me know and I'll rework them.
Current (16px wide):
Alternatives (14px wide):
I did make icons for the non-FD.o ones before realizing they weren't needed. If anyone wants them:
16px:
24px:
Closes #1307