Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptsetup doesn’t use Inter #163

Closed
hanaral opened this issue Feb 4, 2021 · 6 comments
Closed

Cryptsetup doesn’t use Inter #163

hanaral opened this issue Feb 4, 2021 · 6 comments
Assignees

Comments

@hanaral
Copy link

hanaral commented Feb 4, 2021

Problem

The drive encryption unlock screen uses Ubuntu’s font rather than Inter

@davidmhewitt davidmhewitt transferred this issue from elementary/installer Feb 4, 2021
@cassidyjames
Copy link

cassidyjames commented Feb 4, 2021

Photos for context. Similarly, the check disk screen when booting the installer also uses Ubuntu instead of Inter.

PXL_20210204_000857146.jpg PXL_20210203_235928872.jpg

@meisenzahl
Copy link
Member

I'm sorry I mixed up the issues. Sorry for that.

plymouth will fallback to "Sans 12" if no font description is provided.

But "Sans" should be resolved to "Arimo":

$ fc-match sans
Arimo-Regular.ttf: "Arimo" "Regular"

So I'm not quite sure what's happening here...

Originally posted by @meisenzahl in elementary/plymouth-theme#13 (comment)

@meisenzahl is it a matter of the font not being available from the OS? Do we need to do something special with the font to make it available?

Originally posted by @cassidyjames in elementary/plymouth-theme#13 (comment)

@meisenzahl
Copy link
Member

@cassidyjames if I understand it correctly, plymouth is "compiled" into our initramfs. It's just a guess, but maybe in both cases we use only a minimal initramfs where Inter is not available.

@davidmhewitt could that, be the problem?

@davidmhewitt
Copy link
Member

@meisenzahl Yes, correct, when the initramfs is updated, a series of "hook" scripts are ran to copy in the necessary files for the initramfs to run.

It's often better to view the source of a package from the Ubuntu repositories as Canonical often patch stuff. I've found this which looks like the culprit, and we're already patching plymouth, so probably not too much of a big deal to swap out the fonts here:

https://github.com/elementary/os-patches/blob/plymouth-focal-patched/debian/local/plymouth.hook#L116-L163

You could test locally by modifying /usr/share/initramfs-tools/hooks/plymouth.

@meisenzahl
Copy link
Member

@davidmhewitt thanks for looking into this!

@meisenzahl meisenzahl transferred this issue from elementary/plymouth-theme Feb 5, 2021
@meisenzahl meisenzahl self-assigned this Feb 5, 2021
@cassidyjames
Copy link

Fixed by #164

danirabbit pushed a commit that referenced this issue Oct 27, 2022
Don't analyze a compile command with an empty (null) "command"

Closes #163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants