-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to Permission tab of Application Settings #99
Link to Permission tab of Application Settings #99
Conversation
Thanks for working on this! I'm looking at the pre-existing work we have in the GeoClue agent for displaying a link to system settings. It looks like the pattern there is to include a settings link in the body copy like this: Otherwise, if this button doesn't close the dialog it should be in the incidental action position like this: Or if it does close the dialog, it should be in the secondary action position like this: @cassidyjames any thoughts on which feels most natural? |
I'm not sure we need to link to permissions settings in the first place, as I believe the plan is to expose/explain what permissions are being requested (and the implications) before installing. But if we do want to show it here, then I think the inline link feels the best to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Nice work!
Related to #97