-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show devices without releases #195
Conversation
You might want to put those 'up to date' labels inside insensitive buttons, for visual consistency with the fact that the button UI elements are extrusions from the panel that can't just disappear. It also makes is consistent with other similar menus like Bluetooth or Network. |
@meisenzahl I think if we have headings, we don't need the individual labels here. It is redundant and would be cleaner without—plus it would make the action of updating firmware stand out even more. |
@meisenzahl idk if you're still actively working on this, but as of the latest commit it looks like I've lost the "Up to Date" heading for my device that's up to date. 😄 |
@cassidyjames I'm still tackling some issues as you might see 😛 |
@danrabbit thanks for your suggestions! The code is now much better structured. However, I now have the problem that the header with the number of available updates is not updated. Do you have an idea how to implement this? I have been following elementary/switchboard-plug-bluetooth and elementary/appcenter. Bluetooth plug does not show a count of available devices and AppCenter always has the total count at the time the header is added. |
I think I got it 🤔 Peek.2021-02-06.08-37.mp4Sometimes it takes a while until fwupd notices that a device has been plugged in or unplugged. |
…/switchboard-plug-about into show-devices-without-releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Closes #193