Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show devices without releases #195

Merged
merged 10 commits into from
Feb 8, 2021
Merged

Conversation

meisenzahl
Copy link
Member

Closes #193

@meisenzahl
Copy link
Member Author

Simplest solution without splitting items.

Bildschirmfoto von 2021-02-05 19 18 10

@hanaral
Copy link

hanaral commented Feb 5, 2021

You might want to put those 'up to date' labels inside insensitive buttons, for visual consistency with the fact that the button UI elements are extrusions from the panel that can't just disappear. It also makes is consistent with other similar menus like Bluetooth or Network.

@meisenzahl
Copy link
Member Author

@hanaral thanks for your input. I already changed the behavior in #182

@meisenzahl
Copy link
Member Author

Split up with headings

Bildschirmfoto von 2021-02-05 19 42 45

Have to test some corner cases

@cassidyjames
Copy link
Contributor

@meisenzahl I think if we have headings, we don't need the individual labels here. It is redundant and would be cleaner without—plus it would make the action of updating firmware stand out even more.

@cassidyjames
Copy link
Contributor

@meisenzahl idk if you're still actively working on this, but as of the latest commit it looks like I've lost the "Up to Date" heading for my device that's up to date. 😄

@meisenzahl
Copy link
Member Author

@cassidyjames I'm still tackling some issues as you might see 😛

Bildschirmfoto von 2021-02-05 21 04 20

src/Widgets/FirmwareHeaderRow.vala Outdated Show resolved Hide resolved
src/Views/FirmwareView.vala Outdated Show resolved Hide resolved
src/Views/FirmwareView.vala Outdated Show resolved Hide resolved
@meisenzahl
Copy link
Member Author

@danrabbit thanks for your suggestions! The code is now much better structured.

However, I now have the problem that the header with the number of available updates is not updated. Do you have an idea how to implement this?

I have been following elementary/switchboard-plug-bluetooth and elementary/appcenter. Bluetooth plug does not show a count of available devices and AppCenter always has the total count at the time the header is added.

@meisenzahl
Copy link
Member Author

meisenzahl commented Feb 6, 2021

I think I got it 🤔

Peek.2021-02-06.08-37.mp4

Sometimes it takes a while until fwupd notices that a device has been plugged in or unplugged.

@meisenzahl meisenzahl marked this pull request as ready for review February 6, 2021 07:41
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@danirabbit danirabbit merged commit acbb031 into master Feb 8, 2021
@danirabbit danirabbit deleted the show-devices-without-releases branch February 8, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firmware: show devices without releases
4 participants