Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide fallback icon for firmware devices #201

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Provide fallback icon for firmware devices #201

merged 1 commit into from
Feb 9, 2021

Conversation

meisenzahl
Copy link
Member

Closes #200

danirabbit
danirabbit approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, can confirm that this provides a fallback icon. Nice work

@danirabbit danirabbit merged commit 10768b7 into master Feb 9, 2021
@danirabbit danirabbit deleted the provide-fallback-icon-for-firmware-devices branch February 9, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

@cassidyjames cassidyjames Awaiting requested review from cassidyjames

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide fallback icon for firmware devices
2 participants
@meisenzahl @danirabbit