Skip to content

Commit

Permalink
fix: Update tests for Node v18.15.0
Browse files Browse the repository at this point in the history
  • Loading branch information
elementbound authored Mar 18, 2023
1 parent c6a9ecc commit 37bf9c4
Show file tree
Hide file tree
Showing 9 changed files with 21 additions and 17 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,12 @@ jobs:
- uses: actions/checkout@v3
- name: Setup
uses: ./.github/actions/setup.node
- name: Env info
run: |
echo "Node $(node -v)"
echo "pnpm v$(pnpm -v)"
- name: Test
run: pnpm -r test:dump
run: pnpm -r t
perf-test:
runs-on: ubuntu-latest
needs: lint
Expand Down
6 changes: 3 additions & 3 deletions examples/websocket-chat/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@elementbound/nlon-websocket-example",
"version": "0.10.4",
"version": "0.10.5",
"description": "An example app using nlon over WebSockets",
"private": "true",
"main": "src/host.mjs",
Expand All @@ -17,8 +17,8 @@
"author": "Tamas Galffy",
"license": "MIT",
"dependencies": {
"@elementbound/nlon": "workspace:^0.10.4",
"@elementbound/nlon-websocket": "workspace:^0.10.4",
"@elementbound/nlon": "workspace:^0.10.5",
"@elementbound/nlon-websocket": "workspace:^0.10.5",
"express": "^4.18.2",
"pino": "^8.8.0"
},
Expand Down
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "node_modules/lerna/schemas/lerna-schema.json",
"useWorkspaces": true,
"version": "0.10.4"
"version": "0.10.5"
}
4 changes: 2 additions & 2 deletions packages/nlon-socket/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@elementbound/nlon-socket",
"version": "0.10.4",
"version": "0.10.5",
"description": "Socket adapter for nlon",
"main": "index.js",
"scripts": {
Expand All @@ -24,7 +24,7 @@
},
"repository": "github:elementbound/nlon",
"dependencies": {
"@elementbound/nlon": "workspace:^0.10.4"
"@elementbound/nlon": "workspace:^0.10.5"
},
"devDependencies": {
"clean-jsdoc-theme": "^4.2.2",
Expand Down
4 changes: 2 additions & 2 deletions packages/nlon-websocket/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@elementbound/nlon-websocket",
"version": "0.10.4",
"version": "0.10.5",
"description": "WebSocket adapter for nlon",
"main": "index.mjs",
"scripts": {
Expand All @@ -24,7 +24,7 @@
},
"repository": "github:elementbound/nlon",
"dependencies": {
"@elementbound/nlon": "workspace:^0.10.4",
"@elementbound/nlon": "workspace:^0.10.5",
"isomorphic-ws": "^5.0.0",
"ws": "^8.12.1"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/nlon/lib/correspondence/correspondence.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -197,15 +197,15 @@ export class Correspondence extends events.EventEmitter {
* @throws If any of the handlers throw
*/
async * all (...handlers) {
while (this.readable) {
do {
const data = await this.next(...handlers)
if (data !== _CorrespondenceEnd) {
yield Promise.resolve(data)
continue
}

break
}
} while (this.readable)
}

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/nlon/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@elementbound/nlon",
"version": "0.10.4",
"version": "0.10.5",
"description": "Reference implementation of the nlon protocol",
"main": "index.mjs",
"scripts": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ describe('ReadableCorrespondence', () => {
const promise = generator.next()

// Then
assert.rejects(promise)
assert.rejects(promise, 'Didn\'t reject!')
})
// }}}

Expand Down
8 changes: 4 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 37bf9c4

Please sign in to comment.