This repository has been archived by the owner on Oct 22, 2020. It is now read-only.
Revert "Merge pull request #368 from elifesciences/312-push-messages" #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diversemix
suggested changes
Aug 22, 2018
package.json
Outdated
| @@ -139,7 +139,7 @@ | |||
| "joi-browser": "^13.4.0", | |||
| "lint-staged": "^7.2.2", | |||
| "prettier": "^1.8.2", | |||
| "pubsweet": "^2.3.0", | |||
| "pubsweet": "^2.2.8", | |||
There was a problem hiding this comment.
Don't think we should be downgrading these - probably what is causing the failures in the pipeline.
server/dar-server/package.json
Outdated
| @@ -12,6 +12,6 @@ | |||
| "express": "^4.16.2" | |||
| }, | |||
| "peerDependencies": { | |||
| "pubsweet-server": "^8.0.0" | |||
| "pubsweet-server": "^7.0.0" | |||
There was a problem hiding this comment.
Don't think we should be downgrading these - probably what is causing the failures in the pipeline.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This reverts the Websocket subscription, as it doesn't work when the app is served over https. This is due to the subscription url being prefixed with
ws://in pubsweet-clientAny relevant tickets
#368, #507
How has this been tested?
CI