-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
271 remove crowdsource #287
Conversation
WalkthroughThe recent update addresses a minor correction in the Changes
Sequence Diagram(s)(Considering the simplicity of the changes, generating sequence diagrams is not applicable in this scenario since the change did not affect the functionality or control flow.) Tip AI model upgrade
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
See [.github/workflows/maven-release.yml](.github/workflows/maven-release.yml) → | ||
|
||
> [!NOTE] | ||
> To perform a release, go to https://github.com/elimu-ai/model/actions/workflows/maven-release.yml, and press "Run workflow." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using bare URLs.
The URL should be formatted as a Markdown link.
- > To perform a release, go to https://github.com/elimu-ai/model/actions/workflows/maven-release.yml, and press "Run workflow."
+ > To perform a release, go to [this link](https://github.com/elimu-ai/model/actions/workflows/maven-release.yml), and press "Run workflow."
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
> To perform a release, go to https://github.com/elimu-ai/model/actions/workflows/maven-release.yml, and press "Run workflow." | |
> To perform a release, go to [this link](https://github.com/elimu-ai/model/actions/workflows/maven-release.yml), and press "Run workflow." |
Tools
Markdownlint
23-23: null
Bare URL used(MD034, no-bare-urls)
README.md
Outdated
@@ -17,7 +17,12 @@ mvn compile | |||
|
|||
## Release 📦 | |||
|
|||
See [.github/workflows/maven-release.yml](.github/workflows/maven-relevase.yml) | |||
See [.github/workflows/maven-release.yml](.github/workflows/maven-release.yml) → |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing spaces.
There are trailing spaces at the end of this line.
- See [.github/workflows/maven-release.yml](.github/workflows/maven-release.yml) →
+ See [.github/workflows/maven-release.yml](.github/workflows/maven-release.yml)
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
See [.github/workflows/maven-release.yml](.github/workflows/maven-release.yml) → | |
See [.github/workflows/maven-release.yml](.github/workflows/maven-release.yml) |
Tools
Markdownlint
20-20: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
README.md (2)
20-20
: Remove trailing spaces.There are trailing spaces at the end of this line.
- See [.github/workflows/maven-release.yml](.github/workflows/maven-release.yml) + See [.github/workflows/maven-release.yml](.github/workflows/maven-release.yml)
23-23
: Avoid using bare URLs.The URL should be formatted as a Markdown link.
- > To perform a release, go to https://github.com/elimu-ai/model/actions/workflows/maven-release.yml, and press "Run workflow." + > To perform a release, go to [this link](https://github.com/elimu-ai/model/actions/workflows/maven-release.yml), and press "Run workflow."Tools
Markdownlint
23-23: null
Bare URL used(MD034, no-bare-urls)
closes #271