Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /contributions/most-recent #1912

Closed
Tracked by #156
jo-elimu opened this issue Oct 9, 2024 · 6 comments · Fixed by #1916
Closed
Tracked by #156

Remove /contributions/most-recent #1912

jo-elimu opened this issue Oct 9, 2024 · 6 comments · Fixed by #1916
Labels
good first issue Good for newcomers

Comments

@jo-elimu
Copy link
Member

jo-elimu commented Oct 9, 2024

Description

Remove all code related to the URL /contributions/most-recent, i.e. the Controller, JSP, CSS, links in from other pages, etc.

Why?

  • To reduce complexity.
@Aryant-Tripathi
Copy link
Contributor

@jo-elimu , may I allowed to pick this task ?

@jo-elimu
Copy link
Member Author

@Aryant-Tripathi Please do 🙂

Aryant-Tripathi added a commit to Aryant-Tripathi/webapp that referenced this issue Oct 10, 2024
                - Deleted MostRecentContributionsController.java
                - Deleted most-recent.jsp
                - Updated main.jsp to reflect the removal of most recent contributions section
@Aryant-Tripathi
Copy link
Contributor

@jo-elimu If possible may you be able to mark/tag PR as hacktoberfest-accepted / hacktoberfest label. It will help me in contributing a PR in hacktoberfest.

@jo-elimu
Copy link
Member Author

@Aryant-Tripathi Done 👍

@Aryant-Tripathi
Copy link
Contributor

I am sorry @jo-elimu , for this little change I am asking you to do these things,

but I need label hacktoberfest-accepted on the PR.

This is what hactoberfest says:

Your PR was submitted to a repository that is not participating in Hacktoberfest. Maintainers need to add the hacktoberfest topic to the repository, or add the hacktoberfest-accepted label to your PR.
For more information about how exactly we validate PRs for contributors, check the details on our participation page.

@jo-elimu
Copy link
Member Author

Maintainers need to add the hacktoberfest topic to the repository, or add the hacktoberfest-accepted label to your PR.

@Aryant-Tripathi I've added the hacktoberfest topic to the repository: https://github.com/elimu-ai/webapp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants