Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Java 17 #1800

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Upgrade to Java 17 #1800

merged 3 commits into from
Aug 2, 2024

Conversation

jo-elimu
Copy link
Member

@jo-elimu jo-elimu commented Aug 1, 2024

closes #1795

@jo-elimu jo-elimu requested a review from a team as a code owner August 1, 2024 13:40
@jo-elimu jo-elimu linked an issue Aug 1, 2024 that may be closed by this pull request
Copy link
Contributor

coderabbitai bot commented Aug 1, 2024

Walkthrough

This change involves upgrading the Java version used across various GitHub Actions workflows from Java 11 to Java 17. The updates reflect a shift in the project's minimum Java version requirement, aligning the build and test processes with modern Java features and improvements. Additionally, the documentation has been updated to specify this new requirement, ensuring consistency throughout the project.

Changes

Files Change Summary
.github/workflows/maven-build.yml Updated supported Java versions from [11, 17, 21] to [17, 21].
.github/workflows/maven-regression-test.yml Changed Java version from 11 to 17 in two instances.
.github/workflows/maven-release.yml Updated Java version from 11 to 17.
src/main/config/DEPLOY.md Documentation updated to require "Java 17 or newer."

Assessment against linked issues

Objective Addressed Explanation
Upgrade from Java 11 to 17 (#1795, #1691)

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d20bd71 and b019a72.

Files ignored due to path filters (1)
  • pom.xml is excluded by !**/*.xml
Files selected for processing (1)
  • .github/workflows/maven-regression-test.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/maven-regression-test.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot previously approved these changes Aug 1, 2024
coderabbitai[bot]
coderabbitai bot previously approved these changes Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.02%. Comparing base (0b22aaf) to head (b019a72).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1800      +/-   ##
============================================
- Coverage     15.19%   15.02%   -0.18%     
+ Complexity      450      446       -4     
============================================
  Files           249      249              
  Lines          7627     7627              
  Branches        798      798              
============================================
- Hits           1159     1146      -13     
- Misses         6418     6433      +15     
+ Partials         50       48       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

venkatesh2k3
venkatesh2k3 previously approved these changes Aug 1, 2024
#1795

Use `maven-war-plugin` 3.4.0 instead of 2.2

Possible fix for build failure:

```java
Error:  Failed to execute goal org.apache.maven.plugins:maven-war-plugin:2.2:war (default-war) on project webapp: Execution default-war of goal org.apache.maven.plugins:maven-war-plugin:2.2:war failed: Unable to load the mojo 'war' in the plugin 'org.apache.maven.plugins:maven-war-plugin:2.2' due to an API incompatibility: org.codehaus.plexus.component.repository.exception.ComponentLookupException: Cannot access defaults field of Properties
```
@jo-elimu jo-elimu merged commit fcd221d into main Aug 2, 2024
8 of 9 checks passed
@jo-elimu jo-elimu deleted the 1795-upgrade-to-java-17 branch August 2, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Java 17
3 participants