Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Gettext.Macros to generate less code #393

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Refactor Gettext.Macros to generate less code #393

merged 3 commits into from
Aug 19, 2024

Conversation

whatyouhide
Copy link
Contributor

Talked about this with @josevalim this morning.

@coveralls
Copy link

coveralls commented Aug 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build e2539bf17e8f26e7d68c4fa77a4d48c77a4f30f5-PR-393

Details

  • 80 of 85 (94.12%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+2.4%) to 93.373%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/gettext/macros.ex 76 81 93.83%
Files with Coverage Reduction New Missed Lines %
lib/gettext/macros.ex 1 94.0%
Totals Coverage Status
Change from base Build 0cdb06adc52161dae532e9bd99e80a83e5472c64: 2.4%
Covered Lines: 634
Relevant Lines: 679
💛 - Coveralls

josevalim
josevalim reviewed Aug 19, 2024
View reviewed changes
mix.exs Outdated Show resolved Hide resolved
@whatyouhide whatyouhide merged commit d6e3eb5 into main Aug 19, 2024
3 checks passed
@whatyouhide whatyouhide deleted the al/refactor branch August 19, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whatyouhide @coveralls @josevalim