Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip update if check failed #71

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

vshev4enko
Copy link
Contributor

No description provided.

@whatyouhide
Copy link
Contributor

I might be out of it, but how does this differ from exiting with 1 and not updating in that case?

@vshev4enko
Copy link
Contributor Author

outdated.sh returns 1 when e.g curl failed. this exit_code 2 (maybe not the best number for such purpose) intended to differentiate needs to update certs from any other script fail

@whatyouhide
Copy link
Contributor

Aaaah got it. Does curl not use exit status 2?

@vshev4enko
Copy link
Contributor Author

vshev4enko commented Sep 20, 2024

it does https://everything.curl.dev/cmdline/exitcode.html. There are e.g 20 marked as Not used and some up to 100. Not sure which one is better some from the gaps in the 1..99 range or some outside of range to avoid using this code by curl in future. I think we can use 100.

@whatyouhide whatyouhide merged commit d397a57 into elixir-mint:main Sep 23, 2024
3 checks passed
@whatyouhide
Copy link
Contributor

Thanks @vshev4enko 💟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants