-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump gun from 1.3.3 to 2.0.1 #587
Conversation
3de11f7
to
cbacf40
Compare
closes #565 |
It would be great if we merge this change. I was thinking that the place where adapters are is not very scalable. Let me elaborate. By committing adapters in the same repo and referencing their underlaying libraries as
If we create a different repository and dependency for It is just an idea, hope it helps! |
@carrascoacd This is a well-known problem to me. I will suggest joining https://erlef.org/wg/libs-and-frameworks Slack channel or following Discussions at https://github.com/erlef/libs-and-frameworks/discussions since I am going to be creating a topic related to the issue. |
Hello there! is there any plan to merge this? Thanks! |
I'd go with |
7d411d3
to
454bd1d
Compare
Is it a flaky test, preventing to get the PR merged? |
I think we need to change the function
I left this #625 so we can move forward. |
@dependabot recreate |
Dependabot couldn't find the original pull request head commit, cbacf40.
b035b0b
to
af73fc3
Compare
https://github.com/dependabot recreate |
Looks like gun is up-to-date now, so this is no longer needed. |
Bumps gun from 1.3.3 to 2.0.1.
Commits
db0655d
Gun 2.0.1e763216
Update Cowlib to 2.12.133223e7
Update version to 2.0.0a51b1ad
Update READMEe45a925
Update public domain suffix liste3a8fd1
Update copyright lines in preparation for release096dfdf
Update the migration guide for 2.0c8c99b3
Fix intermittent error in stream_info_http test9c0be06
Selective receive in test to avoid receiving wrong messageffa04a5
Linger a little at the end of a shutdown test connectionYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)