Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump gun from 1.3.3 to 2.0.1 #587

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 15, 2023

Bumps gun from 1.3.3 to 2.0.1.

Commits
  • db0655d Gun 2.0.1
  • e763216 Update Cowlib to 2.12.1
  • 33223e7 Update version to 2.0.0
  • a51b1ad Update README
  • e45a925 Update public domain suffix list
  • e3a8fd1 Update copyright lines in preparation for release
  • 096dfdf Update the migration guide for 2.0
  • c8c99b3 Fix intermittent error in stream_info_http test
  • 9c0be06 Selective receive in test to avoid receiving wrong message
  • ffa04a5 Linger a little at the end of a shutdown test connection
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file elixir Pull requests that update Elixir code labels May 15, 2023
@dependabot dependabot bot force-pushed the dependabot/hex/gun-2.0.1 branch 2 times, most recently from 3de11f7 to cbacf40 Compare May 15, 2023 16:41
@yordis yordis marked this pull request as draft May 15, 2023 16:51
@yordis
Copy link
Member

yordis commented May 15, 2023

closes #565

@carrascoacd
Copy link
Contributor

carrascoacd commented Aug 10, 2023

It would be great if we merge this change. I was thinking that the place where adapters are is not very scalable. Let me elaborate. By committing adapters in the same repo and referencing their underlaying libraries as optional you force situations like this:

  • a dep depends on gun 2.0
  • tesla depends optionally on gun 1.x
  • Application dependes on tesla and A. It also uses adapter hackney but has a dependency with gun due to A, hence you have to override gun to 2.x since you are not using the tesla adapter gun and you don't care about it.

If we create a different repository and dependency for tesla_gun_adapter and tesla_<other>_adapter we will be able to avoid this situation, since the simple fact of using Tesla doesn't force you to override third dependencies.

It is just an idea, hope it helps!

@yordis
Copy link
Member

yordis commented Aug 10, 2023

@carrascoacd This is a well-known problem to me. I will suggest joining https://erlef.org/wg/libs-and-frameworks Slack channel or following Discussions at https://github.com/erlef/libs-and-frameworks/discussions since I am going to be creating a topic related to the issue.

@mustela
Copy link

mustela commented Sep 1, 2023

Hello there! is there any plan to merge this? Thanks!

@teamon
Copy link
Member

teamon commented Sep 1, 2023

I'd go with {:gun, ">= 1.0"}. Separate adapter packages are a hell to maintain.

@yordis yordis force-pushed the dependabot/hex/gun-2.0.1 branch 3 times, most recently from 7d411d3 to 454bd1d Compare September 10, 2023 11:09
@yordis yordis marked this pull request as ready for review September 10, 2023 11:09
@egze
Copy link

egze commented Oct 4, 2023

Is it a flaky test, preventing to get the PR merged?

@carrascoacd
Copy link
Contributor

carrascoacd commented Oct 10, 2023

I think we need to change the function request by headers according to

The function request/5,6 sends the entire request, including the request body, immediately. It is therefore not possible to use gun:data(3) after that. You should provide a content-type header. Gun will set the content-length header automatically.

I left this #625 so we can move forward.

@yordis
Copy link
Member

yordis commented Oct 25, 2023

@dependabot recreate

Dependabot couldn't find the original pull request head commit, cbacf40.
@yordis
Copy link
Member

yordis commented Oct 25, 2023

https://github.com/dependabot recreate

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 25, 2023

Looks like gun is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Oct 25, 2023
@dependabot dependabot bot deleted the dependabot/hex/gun-2.0.1 branch October 25, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file elixir Pull requests that update Elixir code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants