Make Logger optional #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I wanted to introduce the possibility to swap the Logger implementation so that users can decide how WaffleEcto will log potential errors.
Having error log from an external library is not always wanted in production project and some might want to have control over that.
This PR gives now the ability to disable the error logs by adding this to a config file
Note : I wanted to go the extra mile and add make this extendable using
@callbackinstead of just adding a boolean to enable, disabled log. I think it might be useful but it also add more bit more code and I don't know if it will be used for anything else than disabling / enabling the log so.. 😄