[Recognizer] Setup CD #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
force-pushed
the
reco-deploy
branch
2 times, most recently
from
55d19a8
to
17b981b
Compare
mickel8
force-pushed
the
reco-deploy
branch
7 times, most recently
from
f052232
to
f6a60ac
Compare
|
Btw, there's something wrong with the tab title on the deployed version Wasn't it |
LVala
approved these changes
Jul 18, 2024
sgfn
reviewed
Jul 18, 2024
Comment on lines
26
to
30
| - name: Checkout the code | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| sparse-checkout: ${{ inputs.app-name }} | ||
|
|
There was a problem hiding this comment.
We don't really need that, do we? The tag is present in the github context, and the container image is pulled from the registry
|
@LVala Github workflows cannot be nested so I prefixed them with |
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR, a new docker Recognizer docker image will be created, published and deployed every time we create a tag
recognizer-vXwhereXcan be anything e.g.v0.1.0v0.1.0-32dfegv0.1.0-dev.Docker image can be pulled with
docker pull ghcr.io/elixir-webrtc/apps/recognizer:0.1.0(so withvstripped) or usinglatest.Deployed version is available under https://recognizer.elixir-webrtc.org