Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recognizer] Use jitter buffer #49

Closed
wants to merge 3 commits into from
Closed

[Recognizer] Use jitter buffer #49

wants to merge 3 commits into from

Conversation

sgfn
Copy link
Member

@sgfn sgfn commented Aug 20, 2024

@sgfn sgfn requested a review from LVala August 20, 2024 15:41
Comment on lines +62 to +64
# {:ex_webrtc, "~> 0.4.0"},
{:ex_webrtc,
github: "elixir-webrtc/ex_webrtc", branch: "sgfn/jitter-buffer", override: true},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to just pin it to ex_webrtc master when Jitter Buffer is merged.

@@ -43,7 +43,7 @@ defmodule RecognizerWeb do
layouts: [html: RecognizerWeb.Layouts]

import Plug.Conn
import RecognizerWeb.Gettext
use Gettext, backend: RecognizerWeb.Gettext
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume these just fix some warnings?

@sgfn
Copy link
Member Author

sgfn commented Sep 20, 2024

Closed in favour of #58

@sgfn sgfn closed this Sep 20, 2024
@sgfn sgfn deleted the sgfn/jitter-buffer branch September 20, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants