Add MDNS resolver #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #27 +/- ##
==========================================
- Coverage 79.04% 78.55% -0.50%
==========================================
Files 18 20 +2
Lines 1002 1049 +47
==========================================
+ Hits 792 824 +32
- Misses 210 225 +15
Continue to review full report in Codecov by Sentry.
|
mickel8
force-pushed
the
mdns-client
branch
5 times, most recently
from
ff85009
to
785b06d
Compare
mickel8
force-pushed
the
mdns-client
branch
7 times, most recently
from
672d828
to
fd2c0d5
Compare
LVala
approved these changes
Mar 13, 2024
Comment on lines
+238
to
+239
| resolve_address = fn | ||
| remote_cand when is_binary(remote_cand.address) -> |
There was a problem hiding this comment.
I'm wondering why this isn't just a private function?
There was a problem hiding this comment.
I put it here as it is very specific to the place where it is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.