Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for port range configuration #43

Merged
merged 2 commits into from
May 20, 2024
Merged

Allow for port range configuration #43

merged 2 commits into from
May 20, 2024

Conversation

LVala
Copy link
Member

@LVala LVala commented May 17, 2024

I changed credo config, as it complains about the Priv.ICEAgent.new which is not complex at all imo.

@LVala LVala marked this pull request as ready for review May 17, 2024 10:40
@LVala LVala requested a review from mickel8 May 17, 2024 10:40
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.09%. Comparing base (e9bf93d) to head (83ea750).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   78.99%   80.09%   +1.09%     
==========================================
  Files          25       25              
  Lines        1419     1422       +3     
==========================================
+ Hits         1121     1139      +18     
+ Misses        298      283      -15     
Files Coverage Δ
lib/ex_ice/ice_agent.ex 54.68% <ø> (ø)
lib/ex_ice/priv/ice_agent.ex 83.94% <100.00%> (+1.79%) ⬆️
lib/ex_ice/priv/gatherer.ex 93.02% <85.71%> (-2.10%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9bf93d...83ea750. Read the comment docs.

@LVala LVala mentioned this pull request May 17, 2024
53 tasks
@LVala LVala self-assigned this May 17, 2024
@LVala LVala merged commit 922c279 into master May 20, 2024
4 checks passed
@LVala LVala deleted the configure-port-range branch May 20, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants