Improve inbound/outbound RTP stats #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 87.16% 86.22% -0.95%
==========================================
Files 36 36
Lines 1854 1887 +33
==========================================
+ Hits 1616 1627 +11
- Misses 238 260 +22
Continue to review full report in Codecov by Sentry.
|
mickel8
approved these changes
Jul 9, 2024
Comment on lines
+28
to
+29
| retransmitted_packets_sent: non_neg_integer(), | ||
| retransmitted_bytes_sent: non_neg_integer(), |
There was a problem hiding this comment.
Nitpick: we can make this a bit shortert
Suggested change
| retransmitted_packets_sent: non_neg_integer(), | |
| retransmitted_bytes_sent: non_neg_integer(), | |
| rtx_packets_sent: non_neg_integer(), | |
| rtx_bytes_sent: non_neg_integer(), |
There was a problem hiding this comment.
This is a stat from W3C, so I'd probably leave it as it is for the sake of compatibility. If it was for me to decide, I'd also use rtx_ prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.