-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add track_id
to packets sent in {:rtcp, ...}
message
#140
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 86.17% 88.31% +2.13%
==========================================
Files 36 36
Lines 1888 1891 +3
==========================================
+ Hits 1627 1670 +43
+ Misses 261 221 -40
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
lib/ex_webrtc/peer_connection.ex
Outdated
@@ -78,7 +81,7 @@ defmodule ExWebRTC.PeerConnection do | |||
| {:track_muted, MediaStreamTrack.id()} | |||
| {:track_ended, MediaStreamTrack.id()} | |||
| {:rtp, MediaStreamTrack.id(), String.t() | nil, ExRTP.Packet.t()}} | |||
| {:rtcp, [ExRTCP.Packet.packet()]} | |||
| {:rtcp, [{ExRTCP.Packet.packet(), MediaStreamTrack.id() | nil}]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| {:rtcp, [{ExRTCP.Packet.packet(), MediaStreamTrack.id() | nil}]} | |
| {:rtcp, [{MediaStreamTrack.id() | nil, ExRTCP.Packet.packet()}]} |
Close #138