Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add track_id to packets sent in {:rtcp, ...} message #140

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Conversation

LVala
Copy link
Member

@LVala LVala commented Jul 18, 2024

Close #138

@LVala LVala self-assigned this Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.31%. Comparing base (9e18881) to head (436b4be).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   86.17%   88.31%   +2.13%     
==========================================
  Files          36       36              
  Lines        1888     1891       +3     
==========================================
+ Hits         1627     1670      +43     
+ Misses        261      221      -40     
Files Coverage Δ
lib/ex_webrtc/peer_connection.ex 85.16% <41.66%> (+3.92%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e18881...436b4be. Read the comment docs.

@LVala LVala marked this pull request as ready for review July 22, 2024 14:40
@LVala LVala requested a review from mickel8 July 22, 2024 14:42
@@ -78,7 +81,7 @@ defmodule ExWebRTC.PeerConnection do
| {:track_muted, MediaStreamTrack.id()}
| {:track_ended, MediaStreamTrack.id()}
| {:rtp, MediaStreamTrack.id(), String.t() | nil, ExRTP.Packet.t()}}
| {:rtcp, [ExRTCP.Packet.packet()]}
| {:rtcp, [{ExRTCP.Packet.packet(), MediaStreamTrack.id() | nil}]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| {:rtcp, [{ExRTCP.Packet.packet(), MediaStreamTrack.id() | nil}]}
| {:rtcp, [{MediaStreamTrack.id() | nil, ExRTCP.Packet.packet()}]}

@LVala LVala merged commit be18ebc into master Jul 22, 2024
1 check failed
@LVala LVala deleted the rtcp-demuxing branch July 22, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to demux incoming RTCP packets
2 participants