Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial about debugging #146

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Add tutorial about debugging #146

merged 7 commits into from
Aug 7, 2024

Conversation

LVala
Copy link
Member

@LVala LVala commented Aug 6, 2024

Close #142

@LVala LVala self-assigned this Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.30%. Comparing base (b286b03) to head (884518b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   88.25%   88.30%   +0.05%     
==========================================
  Files          36       36              
  Lines        1899     1899              
==========================================
+ Hits         1676     1677       +1     
+ Misses        223      222       -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b286b03...884518b. Read the comment docs.

@LVala LVala marked this pull request as ready for review August 7, 2024 10:44
@LVala LVala requested a review from mickel8 August 7, 2024 10:44
to learn more about what's in the WebRTC Internals, or simply explore the tool and see what you find useful.

> #### Other browsers {: .info}
> Chromium's WebRTC Internals is arguably the best tool of this kind. Firefox provides `about:webrtc` page, but it's not nearly as featureful as `chrome::/webrtc-internals`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Chromium's WebRTC Internals is arguably the best tool of this kind. Firefox provides `about:webrtc` page, but it's not nearly as featureful as `chrome::/webrtc-internals`.
> Chromium's WebRTC Internals is arguably the best tool of this kind. Firefox provides `about:webrtc` page, but it's not nearly as featureful as `chrome://webrtc-internals`.

@LVala LVala merged commit 54881fd into master Aug 7, 2024
3 checks passed
@LVala LVala deleted the debugging-tutorial branch August 7, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add section about debugging/observability in tutorials
2 participants