Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore lack of rtcp_mux in rejected m-lines #150

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

LVala
Copy link
Member

@LVala LVala commented Aug 7, 2024

Close #149

The lack of rtcp_mux previously caused PeerConnection to raise an error. This PR fixes this.

Be aware that a remote SDP description with all m-lines rejected might still cause PeerConnection to raise.

@LVala LVala requested a review from mickel8 August 7, 2024 12:45
@LVala LVala self-assigned this Aug 7, 2024
@LVala LVala merged commit 783f25a into master Aug 7, 2024
3 checks passed
@LVala LVala deleted the fix/rejected-mline-rtcp-mux branch August 7, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:missing_rtcp_mux when streaming to firefox
2 participants