Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include DataChannel stats in PeerConnection.get_stats #162

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

LVala
Copy link
Member

@LVala LVala commented Aug 28, 2024

No description provided.

@LVala LVala self-assigned this Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.73%. Comparing base (8109856) to head (8db9248).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/ex_webrtc/sctp_transport.ex 92.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   87.49%   87.73%   +0.23%     
==========================================
  Files          40       40              
  Lines        2199     2225      +26     
==========================================
+ Hits         1924     1952      +28     
+ Misses        275      273       -2     
Files with missing lines Coverage Δ
lib/ex_webrtc/peer_connection.ex 86.20% <100.00%> (+0.35%) ⬆️
lib/ex_webrtc/sctp_transport.ex 82.63% <92.59%> (+1.38%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8109856...8db9248. Read the comment docs.

@LVala LVala marked this pull request as ready for review August 28, 2024 11:19
@LVala LVala requested review from mickel8 and sgfn August 28, 2024 11:19
@LVala LVala merged commit e79d429 into master Aug 29, 2024
3 checks passed
@LVala LVala deleted the data-channel-stats branch August 29, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants