Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop transports on closing PeerConnection #40

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Stop transports on closing PeerConnection #40

merged 4 commits into from
Dec 18, 2023

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Dec 15, 2023

No description provided.

@mickel8 mickel8 mentioned this pull request Dec 15, 2023
53 tasks
@mickel8 mickel8 requested a review from LVala December 15, 2023 16:30
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #40 (3bf50f8) into master (490f43a) will increase coverage by 0.42%.
Report is 1 commits behind head on master.
The diff coverage is 94.11%.

❗ Current head 3bf50f8 differs from pull request most recent head 88eba56. Consider uploading reports for the commit 88eba56 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   87.34%   87.77%   +0.42%     
==========================================
  Files          14       14              
  Lines         664      679      +15     
==========================================
+ Hits          580      596      +16     
+ Misses         84       83       -1     
Files Coverage Δ
lib/ex_webrtc/dtls_transport.ex 83.87% <100.00%> (+0.35%) ⬆️
lib/ex_webrtc/ice_transport.ex 80.00% <100.00%> (+2.22%) ⬆️
lib/ex_webrtc/rtp_sender.ex 100.00% <ø> (ø)
lib/ex_webrtc/rtp_transceiver.ex 91.37% <ø> (ø)
lib/ex_webrtc/peer_connection.ex 85.76% <92.85%> (+1.09%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af29961...88eba56. Read the comment docs.

Base automatically changed from sender-ssrc to master December 18, 2023 10:45
@mickel8 mickel8 merged commit b559388 into master Dec 18, 2023
2 checks passed
@mickel8 mickel8 deleted the pc-close branch December 18, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants