Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comply with rust-lang/rfcs#2140 #815

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

eclairevoyant
Copy link
Contributor

@eclairevoyant eclairevoyant commented Jun 23, 2023

Please follow this template, if applicable.

Description

Renames drain_filter to extract_if and hash_drain_filter to hash_extract_if as per rust-lang/rfcs#2140. Fixes #810 and #841.

Usage

n/a

Showcase

n/a

Additional Notes

n/a

Checklist

Please make sure you can check all the boxes that apply to this PR.

  • All widgets I've added are correctly documented.
  • I added my changes to CHANGELOG.md, if appropriate.
  • The documentation in the docs/content/main directory has been adjusted to reflect my changes.
  • I used cargo fmt to automatically format all code before committing

@bal-e
Copy link

bal-e commented Jul 13, 2023

Not a maintainer, but thanks for making the PR, because I hit the same issue. I tried compiling your branch myself, and I noticed a funny warning in crates/eww/src/error_handling_ctx.rs (line 56): the iterator resulting from extract_if() isn't being used. I think that it's a bug - the correct intention was to remove all the matching items, and this should instead be done with Vec::retain() (this is also mentioned in the documentation for Vec::extract_if()). Can somebody confirm that this is a bug, and if so, can this PR be updated to solve it?

@eclairevoyant eclairevoyant force-pushed the fix-drain-filter branch 2 times, most recently from fc2db6f to 0184092 Compare July 15, 2023 09:15
@eclairevoyant
Copy link
Contributor Author

A warning is not a "bug" but I've updated it nonetheless.

@elkowar elkowar merged commit acf255f into elkowar:master Jul 29, 2023
1 check passed
@eclairevoyant eclairevoyant deleted the fix-drain-filter branch July 29, 2023 12:54
diegoatpitch pushed a commit to diegoatpitch/eww that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] rust features rename drain_filter, hash_drain_filter
3 participants