Skip to content
This repository has been archived by the owner on Jan 20, 2021. It is now read-only.

Add integration and validation tools: TravisCI + CodeClimate & Some refactor fixes #33

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

JoryHogeveen
Copy link

@JoryHogeveen JoryHogeveen commented Mar 30, 2017

First of all, thank you for this plugin! I use it in almost all my installations :)

I noticed this plugin isn't using any CI tools yet so could be a good way to check everything with different versions etc. before deploying on the WP repository.
This PR will add all the required files to integrate with TravisCI and CodeClimate (both free tools for open source projects). You just need to create an acount on both with your GitHub login and enable it for this repository once the PR is merged.

I've also put some minor fixes in there (see "Other changes")

Checks done with TravisCI:

  • PHP 7.1 -> Latest WP verson, both single and multisite
  • PHP 7.0 -> Latest WP verson, both single and multisite
  • PHP 5.6 + Latest WP verson (single installation)
  • PHP hhvm + WP 4.4 (single installation)
  • PHP 5.3 + WP 4.4 (single installation)

Allowed failures:

  • PHP 5.2 + Latest WP verson (single installation)
  • PHP 5.2 + WP 4.4 (single installation)
  • PHP hhvm + WP 4.4 (single installation)

Checks done with CodeClimate

I haven't customized this yet.

PHP Mess Detector

  • Design (all checks)
  • CleanCode (all checks)
  • CodeSize (all checks)
  • Naming (all checks)

PHP Code Sniffer

Other changes:

  • Updated the "Tested up to" version to WP 4.7.x in readme.txt.
  • Added README.md with CI and WP badges for GitHub.
  • Fix load_plugin_textdomain hook (plugins_loaded is too early).
  • Make the class Rename_WP_Login a singleton class.

TODO:

  • Create more PHP Unit Tests. Any ideas?
  • Fix other CodeClimate issues that come up (probably a second PR since the first scan will need to be triggered from the plugin master branch).
    • Some checks (like Nonces) could probably be disabled/ignored in this case.

@JoryHogeveen JoryHogeveen changed the title Add integration and validation tools: TravisCI + CodeClimate Add integration and validation tools: TravisCI + CodeClimate & Some refactor fixes Mar 30, 2017
@maximejobin
Copy link
Collaborator

Amazing work Jory!

I'm a new contributor to this plugin and want to update it. I talked with Ella and she agreed. Would you be interested to help re-validate your work and implement it correctly?

I know it's been 2 years since you did all that but I think your work makes a lot of sense. I hope we can work together on this.

@JoryHogeveen
Copy link
Author

Hi @maximajobin,
Sounds good but I'm on holiday until the 25th!

@maximejobin
Copy link
Collaborator

No problem. Let's connect when you get back!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants