This repository has been archived by the owner on Jan 20, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 71
Add integration and validation tools: TravisCI + CodeClimate & Some refactor fixes #33
Open
JoryHogeveen
wants to merge
15
commits into
ellatrix:master
Choose a base branch
from
JoryHogeveen:add-ci-tools
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wp_parse_url = WP 4.4+ so it's compatible with required version
JoryHogeveen
changed the title
Add integration and validation tools: TravisCI + CodeClimate
Add integration and validation tools: TravisCI + CodeClimate & Some refactor fixes
Mar 30, 2017
Amazing work Jory! I'm a new contributor to this plugin and want to update it. I talked with Ella and she agreed. Would you be interested to help re-validate your work and implement it correctly? I know it's been 2 years since you did all that but I think your work makes a lot of sense. I hope we can work together on this. |
Hi @maximajobin, |
No problem. Let's connect when you get back! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for this plugin! I use it in almost all my installations :)
I noticed this plugin isn't using any CI tools yet so could be a good way to check everything with different versions etc. before deploying on the WP repository.
This PR will add all the required files to integrate with TravisCI and CodeClimate (both free tools for open source projects). You just need to create an acount on both with your GitHub login and enable it for this repository once the PR is merged.
I've also put some minor fixes in there (see "Other changes")
Checks done with TravisCI:
Allowed failures:
Checks done with CodeClimate
I haven't customized this yet.
PHP Mess Detector
PHP Code Sniffer
https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards
Other changes:
load_plugin_textdomain
hook (plugins_loaded
is too early).Rename_WP_Login
a singleton class.TODO: