-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 39 counting model improvements #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip commit; considering variable impact on other bdds should be implemented next
ellmau
added
enhancement
New feature or request
library
This issue or pull request is related to the library
labels
Mar 28, 2022
Currently the stable models (counting-based) has issues with a couple of instances (e.g. adfgen_nacyc_se05_a_02_s_02_b_02_t_02_x_02_c_sXOR_Planning2AF_ferry2.pfile-L2-C1-03.pddl.1.cnf_123_211.apx.adf ) of the examples in the res-folder. Need further debugging and analysis.
As already mentioned in commit 6a47f4d, the mentioned instance takes very long to compute the models (cancelled computation after 4h waiting time). First checks on the results of the trace-output show that the problem gets trivial in roughly 20 steps with an comparable small amount of positive/negative paths in the BDD. This makes the long runtime even more questionable. |
Still more changes to come (e.g. interpretation path counting)
Selecting the minimal number of paths in the bdds, then choosing variable with the highest impact.
considering max-depth too
added a dummy-named-function 'heuristic1' to have a better readable code.
Increased patch-number of the version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
binary
This issue or pull request is related to the binary
enhancement
New feature or request
library
This issue or pull request is related to the library
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves the performance of the stable model computation, by using more bdd-related information, such as
Checklist before creating a non-draft PR
rustfmt
formattedChecklist on Guidelines and Conventions
quickcheck
has been consideredrustdoc
comments are self-reviewed and descriptivepanic!(...)
applications is justified on non-recoverable situationsexpect(...)
is used overunwrap()
(except obvious test-cases)