Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multiple heuristics #48

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Feature/multiple heuristics #48

merged 3 commits into from
Apr 7, 2022

Conversation

ellmau
Copy link
Owner

@ellmau ellmau commented Apr 7, 2022

What does this PR do?

To allow multiple heuristics, a generic approach has been implemented.

Checklist before creating a non-draft PR

  • All tests are passing
  • Clippy has no complains
  • Code is rustfmt formatted
  • Applicable labels are chosen (Note: it is not necessary to replicate the labels from the related issues)
  • There are no other open Pull Requests for the same update/change.
    • If there is a good reason to have another PR for the same update/change, it is well justified.

Checklist on Guidelines and Conventions

  • Commit messages follow our guidelines
  • Code is self-reviewed
  • Naming conventions are met
  • New features are tested
    • quickcheck has been considered
    • All variants are considered and checked
  • Clippy Compiler-exceptions
    • Used in a sparse manner
    • If used, a separate comment describes and justifies its use
  • rustdoc comments are self-reviewed and descriptive
  • Error handling
    • Use of panic!(...) applications is justified on non-recoverable situations
    • expect(...) is used over unwrap() (except obvious test-cases)
  • No unsafe code (exceptions need to be discussed specifically)

@ellmau ellmau added enhancement New feature or request binary This issue or pull request is related to the binary library This issue or pull request is related to the library labels Apr 7, 2022
@ellmau ellmau added this to the Release on crates.io milestone Apr 7, 2022
@ellmau ellmau self-assigned this Apr 7, 2022
@ellmau ellmau merged commit 6c11650 into main Apr 7, 2022
@ellmau ellmau deleted the feature/multiple_heuristics branch April 8, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binary This issue or pull request is related to the binary enhancement New feature or request library This issue or pull request is related to the library
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants