Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing nom-based parser #5

Merged
merged 28 commits into from
Jan 3, 2022
Merged

Implementing nom-based parser #5

merged 28 commits into from
Jan 3, 2022

Conversation

ellmau
Copy link
Owner

@ellmau ellmau commented Dec 9, 2021

Implements to #3

Signed-off-by: Stefan Ellmauthaler [email protected]

@ellmau ellmau added this to the version 0.1.2 milestone Dec 9, 2021
@ellmau ellmau self-assigned this Dec 9, 2021
@ellmau ellmau linked an issue Dec 9, 2021 that may be closed by this pull request
Started to invistage datatypes and the structures to work with the
parser instead of the prototyped approach of version 0.1.1

Signed-off-by: Stefan Ellmauthaler <[email protected]>
relates to #3

Signed-off-by: Stefan Ellmauthaler <[email protected]>
@ellmau
Copy link
Owner Author

ellmau commented Dec 15, 2021

The rework of the parser has implied a rework of the ADF structure as well as the overall computation methods. (see
1cab7a2 and 1830b38)

Therefore the main-application needs to be adapted to use the newly added methods and code.

  • Rewrite of main.rs
  • Replacement of src/adf.rs by src/datatypes/adf/rs

List finished by 9d0601a

@ellmau ellmau marked this pull request as ready for review December 16, 2021 18:59
@ellmau
Copy link
Owner Author

ellmau commented Dec 28, 2021

Note that some tests, which are based on the rework are discussed in Discussion #6

ellmau and others added 2 commits December 31, 2021 14:37
Should help to debug the issues shown in discussion #6

Signed-off-by: Stefan Ellmauthaler <[email protected]>
@ellmau ellmau merged commit 0d5577e into main Jan 3, 2022
@ellmau ellmau deleted the feature/issue_3_parser branch January 10, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a robust parser
1 participant