Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalar configuration #131

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

zAlweNy26
Copy link
Contributor

I saw that the api-reference package from scalar was a bit old and not really used by the plugin.
I also modified a bit the ScalarRender method to use the OpenAPI information object so that is now possible to modify the title of the page.
I hope you like it :)

@marclave marclave self-requested a review July 21, 2024 20:09
@marclave
Copy link
Collaborator

marclave commented Aug 4, 2024

hey @zAlweNy26 ! love this : )

sorry it took me so long to get to this, but if you wanna update the conflicts we can defs get this in!

@zAlweNy26
Copy link
Contributor Author

Hi, I'll resolve the conflicts as soon as possible :)

@zAlweNy26
Copy link
Contributor Author

@marclave everything should be ok now 👍🏽

@zAlweNy26
Copy link
Contributor Author

@marclave I see there is a new conflict, do you want me to resolve it?

@marclave
Copy link
Collaborator

@zAlweNy26 omg im so sorry, yes!

@zAlweNy26
Copy link
Contributor Author

zAlweNy26 commented Sep 26, 2024

@marclave done, it can be merged now :)
PS: If you need help maintaining this package, I can help

@vastamaki
Copy link

Any estimates when this will be released? This is quite critical plugin for the projects I am working with and we kinda suffer from that this is not up to date. Many of the issues/new features are already fixed/implemented in Scalar. I definitely can help maintaining this as well if you happen to need help :-)

@marclave
Copy link
Collaborator

@zAlweNy26 @vastamaki sorry for dropping the ball on this, will merge and get it released.

@marclave marclave merged commit cdb1522 into elysiajs:main Sep 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants