Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pathe to support working in environments without "path" #144

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

Mkassabov
Copy link
Contributor

What this does

Drops import of path in favor of unjs/pathe

Why

path might not exist in all environments (in our specific case cloudflare workers). pathe is a drop in replacement for path that works in all environments.

also fixes this not working in build pipelines that rely on prefixing for native deps (node:path).

@Mkassabov
Copy link
Contributor Author

this also addresses Issue #142

@marclave marclave self-requested a review September 8, 2024 00:03
@marclave
Copy link
Collaborator

marclave commented Sep 8, 2024

awesome work @Mkassabov

@marclave marclave merged commit 2a74d3b into elysiajs:main Sep 8, 2024
1 check passed
@kravetsone
Copy link
Contributor

Js moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants