fix: typebox object schemas without properties key #903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a TypeError in
hasAdditionalProperties
when handling intersection types that include a TypeBox Record. The function fails when processing schemas that havetype: "object"
but noproperties
key.Issue
When using an intersection (
Type.Intersect
) with a Record type from TypeBox, the generated schema is a valid JSON Schema object usingallOf
, but lacks aproperties
key in some of its subschemas. This causeshasAdditionalProperties
to throw a TypeError when attempting to access theproperties
field.Example schema that triggers the bug:
Tests
Added test case for intersection of object + record types
Verified handling of schemas with missing properties key