Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolveAdditionalTextEditsSupport capability to speed up completion #242

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

rrudakov
Copy link
Contributor

Based on this and this

@yyoncho
Copy link
Member

yyoncho commented Jun 30, 2020

This is not sufficient. We have to implement it in lsp-mode as well otherwise the additional text edits won't be applied.

cc @kiennq

@kiennq
Copy link
Member

kiennq commented Jun 30, 2020

Let me make sure if I understand this correctly, we will allow resolveAdditionalTextEditsSupport, and will always resolve completion item when determine it from the popup?
Is there server capability corresponding to this so I can choose to resolve completion item or not?

@yyoncho
Copy link
Member

yyoncho commented Jul 21, 2020

thank you!

@rrudakov
Copy link
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants