Javascript function parameters completion

[kuator]

Thank you for the bug report

• I am using the latest version of lsp-mode related packages.
• I checked FAQ and Troubleshooting sections
• You may also try reproduce the issue using clean environment using the following command: M-x lsp-start-plain

Bug description

typescript-language-server added function parameters completion: typescript-language-server/typescript-language-server#303. Setting the emacs-lsp's lsp-javascript-suggest-complete-function-calls setting doesn't seem to change anything.

Steps to reproduce

  (use-package lsp-mode
    :config
    (add-hook 'c++-mode-hook #'lsp)
    (setq
     lsp-javascript-suggest-complete-function-calls t
     lsp-typescript-suggest-complete-function-calls t)
    :custom
    (lsp-enable-snippet t))

Expected behavior

Function parameters getting completed

Which Language Server did you use?

typescript-language-server

OS

Linux

Error callstack

For some reason, the log becomes 200 000 lines long after completion and I can't paste it

Anything else?

I managed to make it work with neovim

[yyoncho]

Hey @shivjm, willing to take a look?

[shivjm]

Yup, happy to!

[shivjm]

The settings are being correctly propagated from lsp-mode to the server, but the server never returns this kind of suggestion. The suggestion mechanism does seem to work for automatic imports, so it’s specific to this kind of completion. I’ll keep digging.

[kuator]

I'm not sure if it helps, but here's a discussion of the functionality's behaviour: hrsh7th/nvim-cmp#646 (comment)

[yyoncho]

https://github.com/typescript-language-server/typescript-language-server/pull/303/files#r869102064

[kuator]

Thank you!

[yyoncho]

I will keep it open - we might think of some hacky solution to avoid server bugs...

[davidmicah123]

https://openbase.com/js/typescript-language-server/documentation