Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional custom variables for pylsp concerning rope-autoimport #4481

Merged

Conversation

rainij
Copy link
Contributor

@rainij rainij commented Jun 21, 2024

Pylsp supports rope-autoimport (see here). In principle one can enable completions and code actions individually. Currently the respective variables are not exposed by lsp-mode. This PR changes this by adding two additional custom variables.

@github-actions github-actions bot added the client One or more of lsp-mode language clients label Jun 21, 2024
@rainij
Copy link
Contributor Author

rainij commented Jun 21, 2024

This PR is motivated by my question on stackoverflow.

@rainij rainij marked this pull request as ready for review June 21, 2024 18:12
@jcs090218
Copy link
Member

LGTM! Thank you!

@jcs090218 jcs090218 merged commit b196d38 into emacs-lsp:master Jun 28, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants