Refactoring all-the-icons functions #4588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyuenho
force-pushed
the
fix-all-the-icons
branch
2 times, most recently
from
a92df86
to
d700864
Compare
|
@jcs090218 Do you have any feedbacks for this PR? |
jcs090218
approved these changes
Oct 29, 2024
|
LGTM. :) |
|
Can we get this merged? |
wyuenho
force-pushed
the
fix-all-the-icons
branch
from
d700864
to
88ecc7e
Compare
wyuenho
force-pushed
the
fix-all-the-icons
branch
from
88ecc7e
to
d376c29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsp-modeline--code-actions-iconisn't guarded by the proper checks forall-the-icons-octiconfunction, which will causeall-the-iconsto load in the terminal, even though it is not supported. I've also taken the opportunity to refactor the 2 functions that use all-the-icons to use the newlsp-icons-all-the-icons-iconfunction.