Deal with 'workspace/diagnostic/refresh' message #4600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsp-mode does not currently support pull diagnostics. There is a recent change to the spec where the server can notify the client to request diagnostics, when the pull mode is being used. This is implemented incorrectly in a number of servers, which do not first check the relevant client capability. Mitigate this problem by a. Sending client capabilities to day that this is not supported b. Putting a null handler in for the server request message. Closes emacs-lsp#4570
jcs090218
approved these changes
Nov 8, 2024
|
Thanks for taking care of this! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsp-mode does not currently support pull diagnostics.
There is a recent change to the spec where the server can notify the client to request diagnostics, when the pull mode is being used.
This is implemented incorrectly in a number of servers, which do not first check the relevant client capability.
Mitigate this problem by
a. Sending client capabilities to day that this is not supported b. Putting a null handler in for the server request message.
Closes #4570