Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch up signature faces #4608

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

wyuenho
Copy link
Contributor

@wyuenho wyuenho commented Nov 11, 2024

  1. We should not use font-lock-comment-face as the signature posframe border color. There are actually proper faces that frame borders use for this purpose, so let's just use them so we can have a child frame that has borders that look like every other child frame. These are also faces posframe-show will set the border color on.
  2. When propertizing the parameter hints highlight in the signature string, instead of using the eldoc-highlight-function-argument face, let's use a new LSP-specific face that by default inherits from eldoc-highlight-function-argument so users can theme it.

@jcs090218 jcs090218 merged commit e178115 into emacs-lsp:master Nov 12, 2024
11 of 13 checks passed
@jcs090218
Copy link
Member

Make sense! Thank you!

@wyuenho wyuenho deleted the signature-faces branch November 12, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants