Skip to content

Commit

Permalink
Remove Interrupt changes and rebase on master
Browse files Browse the repository at this point in the history
  • Loading branch information
MabezDev committed Jun 19, 2022
1 parent 1b42d16 commit 540ffc6
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 223 deletions.
89 changes: 4 additions & 85 deletions embassy/src/executor/arch/riscv32.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
use super::{raw, Spawner};
use crate::interrupt::{Interrupt, InterruptExt};
use atomic_polyfill::{AtomicBool, Ordering};
use core::marker::PhantomData;
use core::ptr;

use atomic_polyfill::{AtomicBool, Ordering};

use super::{raw, Spawner};

/// global atomic used to keep track of whether there is work to do since sev() is not available on RISCV
///
static SIGNAL_WORK_THREAD_MODE: AtomicBool = AtomicBool::new(false);
Expand Down Expand Up @@ -71,85 +72,3 @@ impl Executor {
}
}
}

/// Interrupt mode executor.
///
/// This executor runs tasks in interrupt mode. The interrupt handler is set up
/// to poll tasks, and when a task is woken the interrupt is pended from software.
///
/// This allows running async tasks at a priority higher than thread mode. One
/// use case is to leave thread mode free for non-async tasks. Another use case is
/// to run multiple executors: one in thread mode for low priority tasks and another in
/// interrupt mode for higher priority tasks. Higher priority tasks will preempt lower
/// priority ones.
///
/// It is even possible to run multiple interrupt mode executors at different priorities,
/// by assigning different priorities to the interrupts. For an example on how to do this,
/// See the 'multiprio' example for 'embassy-nrf'.
///
/// To use it, you have to pick an interrupt that won't be used by the hardware.
/// Some chips reserve some interrupts for this purpose, sometimes named "software interrupts" (SWI).
/// If this is not the case, you may use an interrupt from any unused peripheral.
///
/// It is somewhat more complex to use, it's recommended to use the thread-mode
/// [`Executor`] instead, if it works for your use case.
pub struct InterruptExecutor<I: Interrupt> {
irq: I,
inner: raw::Executor,
not_send: PhantomData<*mut ()>,
}

impl<I: InterruptExt + 'static> InterruptExecutor<I> {
/// Create a new Executor.
pub fn new(mut irq: I) -> Self {
let ctx = &mut irq as *mut I as *mut ();
Self {
irq,
//takes the irq as an argument and pends it
inner: raw::Executor::new(
|ctx| unsafe {
let i = &*(ctx as *mut I);
// trigger the interrupt to indirectly call start()
// when the interrupt is serviced
i.pend();
},
ctx,
),
not_send: PhantomData,
}
}

/// Start the executor.
///
/// The `init` closure is called from interrupt mode, with a [`Spawner`] that spawns tasks on
/// this executor. Use it to spawn the initial task(s). After `init` returns,
/// the interrupt is configured so that the executor starts running the tasks.
/// Once the executor is started, `start` returns.
///
/// To spawn more tasks later, you may keep copies of the [`Spawner`] (it is `Copy`),
/// for example by passing it as an argument to the initial tasks.
///
/// This function requires `&'static mut self`. This means you have to store the
/// Executor instance in a place where it'll live forever and grants you mutable
/// access. There's a few ways to do this:
///
/// - a [Forever](crate::util::Forever) (safe)
/// - a `static mut` (unsafe)
/// - a local variable in a function you know never returns (like `fn main() -> !`), upgrading its lifetime with `transmute`. (unsafe)
pub fn start(&'static mut self, init: impl FnOnce(Spawner) + Send) {
self.irq.disable();

init(self.inner.spawner());
//set interrupt handler to call poll() using this executor, then disable interrupt
self.irq.set_handler(|ctx| unsafe {
//unpend interrupt first, so it may re-trigger if it is signalled again

let executor = &*(ctx as *const Self);
executor.irq.unpend();
executor.inner.poll();
});
self.irq.set_handler_context(self as *const _ as _);

self.irq.enable();
}
}
50 changes: 0 additions & 50 deletions embassy/src/interrupt.rs

This file was deleted.

88 changes: 0 additions & 88 deletions embassy/src/interrupt/cortex_m.rs

This file was deleted.

0 comments on commit 540ffc6

Please sign in to comment.