Remove unnecessary use of atomic-polyfill. #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
force-pushed
the
remove-atomic-polyfill
branch
from
97d5486
to
03a6a54
Compare
- Fixes race condition that could cause losing irqs (because `if flags != 0` was clearing all) - Doesn't need CAS, which is nice for thumbv6.
Only use it when CAS is actually needed.
Dirbaio
force-pushed
the
remove-atomic-polyfill
branch
from
03a6a54
to
10c9cc3
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 23, 2022
1125: Remove unnecessary use of atomic-polyfill. r=Dirbaio a=Dirbaio Only use it when CAS is actually needed. Co-authored-by: Dario Nieuwenhuis <[email protected]>
|
Build failed: |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use it when CAS is actually needed.